Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HDF5 error in macOS ParaView build #521

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Fix HDF5 error in macOS ParaView build #521

merged 2 commits into from
Oct 28, 2020

Conversation

pierre-guillou
Copy link
Contributor

Today, an Xcode update in the macOS image in Azure changed the default compiler flags:

Clang now reports an error when you use a function without an explicit declaration when building C or Objective-C code for macOS (-Werror=implicit-function-declaration flag is on). This additional error detection unifies Clang’s behavior for iOS/tvOS and macOS 64-bit targets for this diagnostic. (49917738)

(from the Xcode 12 Release Notes)

This broke the vtkhdf5 build in our CI pipelines.
This PR aims at solving this issue by removing the offended compiler flag.

Enjoy,
Pierre

@pierre-guillou
Copy link
Contributor Author

Trying to disable the default warning did not work.
New attempt: follow what's recommanded in this issue to switch to an older Xcode version.
Since we don't own the offended code, I'd rather not patch it.

@julien-tierny
Copy link
Collaborator

awesome pierre, thanks!

@julien-tierny julien-tierny merged commit 938816d into topology-tool-kit:dev Oct 28, 2020
@pierre-guillou pierre-guillou deleted the hdf5_fix branch October 28, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierre-guillou @julien-tierny